Skip to content

[TASK] Drop magic method forwarding in OutputFormat #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2025
Merged

[TASK] Drop magic method forwarding in OutputFormat #898

merged 1 commit into from
Mar 13, 2025

Conversation

oliverklee
Copy link
Collaborator

No description provided.

@oliverklee oliverklee self-assigned this Feb 10, 2025
@oliverklee oliverklee marked this pull request as draft February 10, 2025 09:14
@coveralls
Copy link

coveralls commented Feb 10, 2025 •
edited
Loading

Coverage Status

coverage: 55.84% (+0.1%) from 55.721%
when pulling 7e34b1d on cleanup/avoid-forwarding
into c226c04 on main.

@oliverklee oliverklee mentioned this pull request Feb 10, 2025
Merged
@oliverklee

This comment was marked as outdated.

Sign in to view
@oliverklee oliverklee force-pushed the cleanup/avoid-forwarding branch 17 times, most recently from 35d5c71 to adc2fd0 Compare February 16, 2025 21:19
@oliverklee oliverklee force-pushed the cleanup/avoid-forwarding branch 6 times, most recently from 880a39b to f7221ad Compare February 24, 2025 09:52
@oliverklee oliverklee force-pushed the cleanup/avoid-forwarding branch 15 times, most recently from 5eace31 to 7eb5e19 Compare March 12, 2025 17:56
@oliverklee oliverklee changed the title [TASK] Avoid magic method forwarding in OutputFormat [TASK] Drop magic method forwarding in OutputFormat Mar 12, 2025
@oliverklee oliverklee force-pushed the cleanup/avoid-forwarding branch from 7eb5e19 to 7ce2036 Compare March 12, 2025 18:02
@oliverklee oliverklee marked this pull request as ready for review March 12, 2025 18:11
@oliverklee oliverklee requested a review from JakeQZ March 12, 2025 18:11
JakeQZ
JakeQZ reviewed Mar 12, 2025
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a changelog entry? There was one for the deprecation of this in #894.

@oliverklee oliverklee force-pushed the cleanup/avoid-forwarding branch 2 times, most recently from ea24e22 to 11ee02d Compare March 13, 2025 17:19
@oliverklee oliverklee force-pushed the cleanup/avoid-forwarding branch from 11ee02d to 7e34b1d Compare March 13, 2025 17:20
@oliverklee oliverklee requested a review from JakeQZ March 13, 2025 17:20
@oliverklee
Copy link
Collaborator Author

Sorry, I seem to have missed your comment. I've added a changelog entry now and repushed.

@JakeQZ JakeQZ merged commit 38de556 into main Mar 13, 2025
21 checks passed
@JakeQZ JakeQZ deleted the cleanup/avoid-forwarding branch March 13, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels
None yet
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @JakeQZ