Skip to content

[TASK] Mark OutputFormat::nextLevel() as @internal #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2025
Merged

[TASK] Mark OutputFormat::nextLevel() as @internal #901

merged 1 commit into from
Feb 11, 2025

Conversation

oliverklee
Copy link
Collaborator

This method is used internally for rendering the CSS, and it is not intended to be called from outside this library.

@oliverklee oliverklee self-assigned this Feb 10, 2025
@coveralls
Copy link

coveralls commented Feb 10, 2025 •
edited
Loading

Coverage Status

coverage: 49.156%. remained the same
when pulling 3a03cc8 on task/internal-next-level
into 4322d97 on main.

@oliverklee
[TASK] Mark OutputFormat::nextLevel() as @internal
3a03cc8 
This method is used internally for rendering the CSS, and it is
not intended to be called from outside this library.
@oliverklee oliverklee force-pushed the task/internal-next-level branch from ea29948 to 3a03cc8 Compare February 10, 2025 11:14
JakeQZ
JakeQZ approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This functionality perhaps belongs in OutputFormatter.

@JakeQZ JakeQZ merged commit bcbdf4b into main Feb 11, 2025
21 checks passed
@JakeQZ JakeQZ deleted the task/internal-next-level branch February 11, 2025 02:31
oliverklee added a commit that referenced this pull request Feb 11, 2025
@oliverklee
[TASK] Mark OutputFormat::nextLevel() as @internal
811c894 
This method is used internally for rendering the CSS, and it is
not intended to be called from outside this library.

This is the V8.x backport of #901.
@oliverklee oliverklee mentioned this pull request Feb 11, 2025
Merged
JakeQZ pushed a commit that referenced this pull request Feb 11, 2025
@oliverklee
[TASK] Mark OutputFormat::nextLevel() as @internal (#905)
b407f21 
This method is used internally for rendering the CSS, and it is
not intended to be called from outside this library.

This is the V8.x backport of #901.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

@sabberworm sabberworm Awaiting requested review from sabberworm

Assignees

@oliverklee oliverklee

Labels
to-backport
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @JakeQZ