Skip to content

[TASK] Add strict PHPStan rules #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2025
Merged

[TASK] Add strict PHPStan rules #909

merged 1 commit into from
Feb 13, 2025

Conversation

oliverklee
Copy link
Collaborator

Now we are using the same static analysis tools as our sister project.

@oliverklee oliverklee self-assigned this Feb 11, 2025
@oliverklee oliverklee marked this pull request as draft February 11, 2025 15:08
@oliverklee
[TASK] Add strict PHPStan rules
c928057 
Now we are using the same static analysis tools as our sister
project.
@oliverklee oliverklee force-pushed the task/phpstan-strict-rules branch from d474517 to c928057 Compare February 11, 2025 19:13
@oliverklee oliverklee marked this pull request as ready for review February 11, 2025 19:13
@JakeQZ JakeQZ merged commit 62a2e65 into main Feb 13, 2025
21 checks passed
@JakeQZ JakeQZ deleted the task/phpstan-strict-rules branch February 13, 2025 02:05
@coveralls
Copy link

coveralls commented Feb 13, 2025 •
edited
Loading

Coverage Status

coverage: 49.156%. first build
when pulling d474517 on task/phpstan-strict-rules
into b3e83b8 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

@sabberworm sabberworm Awaiting requested review from sabberworm

Assignees

@oliverklee oliverklee

Labels
None yet
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @JakeQZ