Skip to content

RuleSet::addRule() insert position support. #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2016
Merged

RuleSet::addRule() insert position support. #96

merged 1 commit into from
Jul 19, 2016

Conversation

IceReaper
Copy link
Contributor

I'm currently using this lib to auto-prefix css rules for a wider browser support without the need to manually add all those rules. This requires me to add the new prefixed rules before the unprefixed one. I Made some additions to allow you to specify the exact location where the final Rule should be:

@sabberworm
Copy link
Collaborator

Cool, thanks.

Could you add a few unit tests for this feature?

Also, I think the API could be simpler: append the rule to the existing rules if $oSibling is null, prepend before $oSibling othewise. This way, any position can be adressed and we don’t need $bPrepend at all.

@FMCorz
Copy link

FMCorz commented Jul 19, 2016

@IceReaper Do you have that library to auto-prefix CSS lying around? I'd be interested in it.

@sabberworm sabberworm merged commit d0c0a47 into MyIntervals:master Jul 19, 2016
@IceReaper
Copy link
Contributor Author

@FMCorz Sorry, left all the sources with my old employer, got a new job and have no longer access to them. Sorry :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants