Skip to content

[CLEANUP] Use accessors in OutputFormatter #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2025
Merged

[CLEANUP] Use accessors in OutputFormatter #966

merged 1 commit into from
Feb 20, 2025

Conversation

oliverklee
Copy link
Collaborator

Avoid direct access to OutputFormat properties as well as variable access and magic methods.

Also drop some dead code.

We might possibly want to drop the space method altogether, but that's out of scope for this change.

@oliverklee
[CLEANUP] Use accessors in OutputFormatter
9583550 
Avoid direct access to `OutputFormat` properties as well
as variable access and magic methods.

Also drop some dead code.

We might possibly want to drop the `space` method altogether,
but that's out of scope for this change.
@oliverklee oliverklee requested a review from JakeQZ February 20, 2025 11:16
@oliverklee oliverklee self-assigned this Feb 20, 2025
@coveralls
Copy link

Coverage Status

coverage: 52.281% (+0.6%) from 51.654%
when pulling 9583550 on cleanup/accessors-in-outputformatter
into ee3d57c on main.

JakeQZ
JakeQZ requested changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does indeed seem that the $sType parameter is now unused and can be removed.

Whilst making this change, could we not also remove the Hungarian notation from $sSpaceString?

@oliverklee
Copy link
Collaborator Author

Whilst making this change, could we not also remove the Hungarian notation from $sSpaceString?

I'd prefer to do that in a separate change.

JakeQZ
JakeQZ approved these changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whilst making this change, could we not also remove the Hungarian notation from $sSpaceString?

I'd prefer to do that in a separate change.

OK.

@JakeQZ JakeQZ merged commit d607453 into main Feb 20, 2025
21 checks passed
@JakeQZ JakeQZ deleted the cleanup/accessors-in-outputformatter branch February 20, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels
cleanup
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @JakeQZ