Skip to content

[CLEANUP] Drop some comments from testcases #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2025
Merged

[CLEANUP] Drop some comments from testcases #973

merged 1 commit into from
Feb 25, 2025

Conversation

oliverklee
Copy link
Collaborator

@oliverklee oliverklee commented Feb 23, 2025 •
edited
Loading

These comments are no longer needed now that the abstract base classes have their own testcases.

@oliverklee oliverklee requested a review from JakeQZ February 23, 2025 22:38
@oliverklee oliverklee self-assigned this Feb 23, 2025
@coveralls
Copy link

coveralls commented Feb 23, 2025 •
edited
Loading

Coverage Status

coverage: 54.259%. remained the same
when pulling c8e44d0 on cleanup/csslist-tests
into ce26af6 on main.

JakeQZ

This comment was marked as outdated.

Sign in to view

@oliverklee

This comment was marked as outdated.

Sign in to view
@oliverklee oliverklee requested a review from JakeQZ February 24, 2025 09:44
JakeQZ

This comment was marked as outdated.

Sign in to view

@oliverklee oliverklee force-pushed the cleanup/csslist-tests branch from 6cd9d9f to 4ac19de Compare February 24, 2025 11:04
oliverklee added a commit that referenced this pull request Feb 24, 2025
@oliverklee
[CLEANUP] Add some comments for grouping tests
746cb53 
Part of #973
@oliverklee oliverklee mentioned this pull request Feb 24, 2025
Merged
@oliverklee

This comment was marked as outdated.

Sign in to view
@oliverklee oliverklee marked this pull request as draft February 24, 2025 11:14
JakeQZ pushed a commit that referenced this pull request Feb 24, 2025
@oliverklee
[CLEANUP] Add some comments for grouping tests (#978)
321dc5e 
Part of #973
@oliverklee oliverklee force-pushed the cleanup/csslist-tests branch 3 times, most recently from ddd2da5 to 6c2fd9b Compare February 24, 2025 14:09
@oliverklee oliverklee changed the title [CLEANUP] Reorder and group some tests for CSSList [CLEANUP] Reorder some tests for the CSSList namespace Feb 24, 2025
@oliverklee oliverklee force-pushed the cleanup/csslist-tests branch from 6c2fd9b to 5c76a65 Compare February 24, 2025 14:10
@oliverklee oliverklee changed the title [CLEANUP] Reorder some tests for the CSSList namespace [CLEANUP] Drop some comments from testcases Feb 25, 2025
@oliverklee
[CLEANUP] Drop some comments from testcases
c8e44d0 
These comments are no longer needed now that the
abstract base classes have their own testcases.
@oliverklee oliverklee force-pushed the cleanup/csslist-tests branch from 5c76a65 to c8e44d0 Compare February 25, 2025 08:50
@oliverklee oliverklee marked this pull request as ready for review February 25, 2025 08:51
@oliverklee oliverklee requested a review from JakeQZ February 25, 2025 08:51
JakeQZ
JakeQZ approved these changes Feb 25, 2025
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They were temporarily in place during the refactoring.

@JakeQZ JakeQZ merged commit 66fbb73 into main Feb 25, 2025
21 checks passed
@JakeQZ JakeQZ deleted the cleanup/csslist-tests branch February 25, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels
cleanup
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @JakeQZ