Skip to content

[TASK] Add dedicated tests for the abstract CSSList class #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2025
Merged

[TASK] Add dedicated tests for the abstract CSSList class #979

merged 1 commit into from
Feb 24, 2025

Conversation

oliverklee
Copy link
Collaborator

No description provided.

@oliverklee oliverklee requested a review from JakeQZ February 24, 2025 12:09
@oliverklee oliverklee self-assigned this Feb 24, 2025
@oliverklee oliverklee changed the title [TASK] Add dedicated tests for the abstractg CSSList class [TASK] Add dedicated tests for the abstract CSSList class Feb 24, 2025
@coveralls
Copy link

coveralls commented Feb 24, 2025 •
edited
Loading

Coverage Status

coverage: 53.778%. remained the same
when pulling 95c48a4 on task/tests/csslist
into 321dc5e on main.

JakeQZ
JakeQZ approved these changes Feb 24, 2025
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would have preferred a slightly smaller manageable chunk, but I can at least see what's going on with this change.

@JakeQZ JakeQZ merged commit c71c8a3 into main Feb 24, 2025
21 checks passed
@JakeQZ JakeQZ deleted the task/tests/csslist branch February 24, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels
None yet
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @JakeQZ