Skip to content

[TASK] Move CalcRuleValueListTest to unit tests #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

oliverklee
Copy link
Collaborator

Also add the missing @covers annotations for the superclasses of the tested class.

Part of #758.

Also add the missing `@covers` annotations for the superclasses
of the tested class.

Part of #758.
@coveralls
Copy link

Coverage Status

coverage: 54.283% (+0.6%) from 53.705%
when pulling 01daae8 on task/tests/calcrulevaluelist
into 5c193b9 on main.

Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know if this was ready for review, since none was requested, but it looks fine, so I've approved it, allowing you to merge it if it was indeed ready. (I don't know what happens if you push further changes - hopefully in that case the PR will revert to a 'review required' status.)

@oliverklee
Copy link
Collaborator Author

Don't know if this was ready for review, since none was requested, but it looks fine, so I've approved it, allowing you to merge it.

Thanks! Yes, that's helpful. (I forgot to request a review in two PRs, and hence it was not visible whether I forgot to request a review or whether to set them to draft status.)

@oliverklee oliverklee merged commit 77019a4 into main Feb 25, 2025
21 checks passed
@oliverklee oliverklee deleted the task/tests/calcrulevaluelist branch February 25, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants