anticipated changes needed for webpack v4 support?

[thescientist13]

Wondering if any changes will be needed for v4?
https://medium.com/webpack/webpack-4-migration-guide-for-plugins-loaders-20a79b927202

Likely this.option?

I know that ExtractTextWebpackPlugin is still awaiting v4 support

Is there any plan for an upgrade? Any pointers for someone to contribute it? Thanks for the great work on this plugin! 🙏 ✌️

[NMFR]

A quick glance of the changes makes me believe the plugin should still run on webpack v4 (although i didn't test it yet) but webpack will probably emit deprecation warnings.

Must likely we need to change last-call-webpack-plugins implementation to completely conform with v4 plugin system changes (optimize-css-assets-webpack-plugin uses last-call-webpack-plugin dependency to interact with webpack bundle pipeline).

Lately i haven't had much time to solve issues but i intend to work on them in the next weekend.
We are open to PRs if you wish to contribute :)
For this issue the changes should start on last-call-webpack-plugin repo.
last-call-webpack-plugin allows to process webpack assets, just give it a RegEx (to filter what assets to process) and a process function.
last-call-webpack-plugin should be changed to conform with webpack v4 plugin system changes.

Thanks for the support :)

[thescientist13]

Great, thanks for the feedback @NMFR ! Will try and take a look this week 👍

Oh, I've been looking into helping out another plugin too (anthonygore/html-critical-webpack-plugin#10) with upgrading to v4, and have started off by writing some unit tests for them (they didn't have any) first, before doing the upgrade. Would you be opposed to that here as a separate, preliminary PR? I don't mind taking that on with a little help if need be.

[NMFR]

For tests see issue #31

I believe some base work was started.

[thescientist13]

thanks @NMFR will do!

[mjprude]

Hey @thescientist13 we've started work on testing this plugin here and are iterating on that as time permits to get it into a fully PRable state.
We'd welcome contributions (see the unchecked items) but it might make more sense to start with the last-call-webpack-plugin as @NMFR suggested. Be in touch if you do start working on tests (or see an issue in tests with the v4 migration) so we don't end up duplicating work. Thanks!

[NMFR]

I just released optimize-css-assets-webpack-plugin@4.0.0 supporting the new webpack v4 plugin API.

PS: I did some small tests on optimize-css-assets-webpack-plugin@3.2.0 and besides the deprecation warning the plugin seemed to work correctly with webpack v4.

[thescientist13]

Thanks @NMFR !

[thescientist13]

I just tested and all is looking good in my project! thanks for the great work on this plugin! 🙏 🎉