Bumping cssnano version to resolve NPMJS advisory
#165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I installed the libraries deps locall with `npm install`. Noticed the npm audit was alerting of 2 high severity advisories. One of them being [NPM Advisory #1755](https://www.npmjs.com/advisories/1755). After looking at the subdependancies in the npm audit output, I simply updated `cssnano` to see if that would resolve the advisory.
|
Upon further digging into the v5.0.6 release of this library, I noticed the maintainer rolled back the cssnano upgrade seen here in this diff: https://github.com/NMFR/optimize-css-assets-webpack-plugin/pull/156/files. As well as, running the tests my proposed change does seem to break some functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I installed this libraries dependencies locally with
npm install. Noticed the npm auditwas alerting of 2 high severity advisories. One of them being #1755.
After looking at the sub-dependancies in the
npm auditoutput, I simply updatedcssnanowithnpm auditto see if that would resolve the advisory.I'm attempting to patch this CVE here in order to enable an update in the
rails/webpackerruby gem.I didn't see a CONTRIBUTING.md doc in the source, so please let me know if this meets your standards.