making it work with webpack compression plugin #18
Conversation
webpack compression plugin use the phase 'compilation.optimize-assets' so we should use the phase 'compilation.optimize-chunk-assets'
|
This will solve the problem but i need to check if it does not break with Thanks for the PR. |
|
i have already test it with the "extract-text-webpack-plugin" anw you are welcome |
index.js
Outdated
| @@ -23,6 +23,7 @@ function OptimizeCssAssetsPlugin(options) { | |||
| this.lastCallInstance = new LastCallWebpackPlugin({ | |||
| assetProcessors: [ | |||
| { | |||
| phase: 'compilation.optimize-chunk-assets', | |||
There was a problem hiding this comment.
Please use LastCallWebpackPlugin.PHASE.OPTIMIZE_CHUNK_ASSETS.
There was a problem hiding this comment.
this didn't work ! the constant PHASE.OPTIMIZE_CHUNK_ASSETS is in the prototype (object) not in the exports
There was a problem hiding this comment.
unless we use LastCallWebpackPlugin.prototype.PHASE.OPTIMIZE_CHUNK_ASSETS
There was a problem hiding this comment.
My bad, i put it in the prototype by mistake.
Use LastCallWebpackPlugin.prototype.PHASE.OPTIMIZE_CHUNK_ASSETS, i will fix it later (with a change in the LastCallWebpackPlugin).
|
ok can you check it now |
webpack compression plugin use the phase 'compilation.optimize-assets' so we should use the phase 'compilation.optimize-chunk-assets'