Skip to content

Add tests #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
NMFR merged 1 commit into from
Mar 25, 2018
Merged

Add tests #39

NMFR merged 1 commit into from
Mar 25, 2018

Conversation

@dwschrashun
Copy link
Contributor

@dwschrashun dwschrashun commented Mar 19, 2018

  • Add Jest and necessary configuration
  • Test that only files that match the assetNameRegExp option get processed by the plugin.
  • Test that cssProcessor gets called with the passed cssProcessorOptions object and
  • Test the value returned by the Promise (returned by calling cssProcessor) ends up written to the asset.
  • Test that CSS optimization gets run
  • Update README

Please see #31 for more information.

Resources:

Co-authored-by: Scott Norvell scottlnorvell@gmail.com
Co-authored-by: Doug Schrashun thejazzface@gmail.com

@ScottLNorvell @dwschrashun
Add tests
9211251 
* add Jest, unit tests, webpack integration tests, test helpers
* update README

Co-authored-by: Scott Norvell <scottlnorvell@gmail.com>
Co-authored-by: Doug Schrashun <thejazzface@gmail.com>
@NMFR NMFR merged commit 8ad6e6f into NMFR:master Mar 25, 2018
@NMFR
Copy link
Owner

NMFR commented Mar 25, 2018

Thx for the help guys :)

@dwschrashun
Copy link
Contributor Author

dwschrashun commented Mar 26, 2018

Our pleasure. Thanks for the plugin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dwschrashun @NMFR @ScottLNorvell