Enable safe flag by default in the docs. #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

NMFR merged 1 commit into NMFR:master from dtinth:patch-1

Jun 19, 2018

Contributor

dtinth commented Jun 19, 2018

When I added optimize-css-assets-webpack-plugin I noticed that some animations are not working. It turned out that:

Default behavior of cssnano v3 is unsafe. Unused @keyframes are removed and @keyframes names are minified.
We use code splitting.
Therefore, each chunk of CSS assets is minified separately, causing name clashes. Many keyframe rules were renamed as @keyframes a

This PR makes the copy-and-paste example safer to use by default.


          Enable safe flag by default in the docs.

af5e436

NMFR merged commit d084a55 into NMFR:master

Owner

NMFR commented Jun 19, 2018

Thanks for the help :)

frenzzy mentioned this pull request

Can update cssnano from 3.10 to 4.0? #60

Closed

andrewjtait mentioned this pull request

Safe CSS processor options Sage/carbon-factory#201

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet