Skip to content

Fixes @font-face nested in @media #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
NV merged 2 commits into from
Nov 11, 2019
Merged

Fixes @font-face nested in @media #103

NV merged 2 commits into from
Nov 11, 2019

Conversation

@jonkemp
Copy link
Contributor

@jonkemp jonkemp commented Oct 13, 2019

Fixes #102

@NV
Copy link
Owner

NV commented Nov 3, 2019

Could you add tests to spec/parse.spec.js?

@jonkemp
Copy link
Contributor Author

jonkemp commented Nov 4, 2019 •
edited
Loading

@NV I don't understand how to run the tests. I added a test, but I'm not sure it's right.

@NV NV merged commit ab29a6e into NV:master Nov 11, 2019
@NV
Copy link
Owner

NV commented Nov 11, 2019

Looks good! Thank you for fixing this!

@dyatko dyatko mentioned this pull request Nov 12, 2019
Closed
@NV
Copy link
Owner

NV commented Nov 13, 2019

This broke nested media queries :(

https://nv.github.io/CSSOM/docs/parse.html#css=%40media%20a%20%7B%0A%20%20%40media%20b%20%7B%0A%20%20%20%20h1%20%7Bcolor%3A%20yellow%7D%0A%20%20%7D%0A%7D%0A

@media a {
  @media b {
    h1 {color: yellow}
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can't parse @font-face nested in @media.

2 participants

@jonkemp @NV