IE9 & IE10 support #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced __define[G|S]etter__ with Object.defineProperty. Replaced String.trimRight with String.replace(/\s+$/,"") because trimRight is not ECMAScript5 function and IE does not support it.
Contributor
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced define[G|S]etter with Object.defineProperty for IE9 and later. Since some existing code (e.g, CSSStyleDeclaration.js) only supports IE9 and later, I think it is reasonable to replacing them without backward compatibility.
Also, replaced String.trimRight with String.replace(/\s+$/,"") because trimRight
is not ECMAScript5 function and IE does not support it.