Added fix for handling of spaces within parenthesis in values. #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dded handling of nested parenthesis in a value so that it doesn't leave the value parenthesis state until all open parenthesis are matched with a close. Added a test for the case I ran across this problem where I had a linear-gradient with an RGBA value for the second transition point, but transparent for the first. The space was dropped after the transparent, but not the rgba value because the closing paren of the RGBA value transitioned back into the value state from value-parenthesis.
NV
requested changes
Jan 19, 2017
Owner
NV
left a comment
There was a problem hiding this comment.
Thank you for your patch!
Please fix coding style issues and it's good to be merged.
lib/parse.js
Outdated
|
|
||
| var index; | ||
| var buffer = ""; | ||
| var valueParenthesisDepth=0; |
lib/parse.js
Outdated
| // ie css expression mode | ||
| if (buffer.trim() === 'expression') { | ||
| var info = (new CSSOM.CSSValueExpression(token, i)).parse(); | ||
| var info = (new CSSOM.CSSValueExpression(token, i)).parse(); |
lib/parse.js
Outdated
| if (state === 'value-parenthesis') { | ||
| state = 'value'; | ||
| valueParenthesisDepth--; | ||
| if(valueParenthesisDepth === 0) state = 'value'; |
Contributor
Author
|
Ok - made the requested changes. Thanks! |
Contributor
Author
|
whoops -just realized I made the changes in the wrong branch. Will have those submitted in just a minute. |
…- the else if check that increased the valueParenthsisDepth was part of the wrong if block.
Contributor
Author
|
Ok - I've got that up now. I also fixed a bug in my original PR - the else if block that incremented the valueParenthesisDepth was in the wrong if - it was inside the block for state === 'value'. Let me know if you want me to squash these commits. |
NV
approved these changes
Jan 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added handling of nested parenthesis in a value so that it doesn't leave the value-parenthesis state until all open parenthesis are matched with a close.
Added a test for the case I ran across this problem where I had a linear-gradient with an RGBA value for the second transition point, but transparent for the first. The space was dropped after the transparent, but not the rgba value because the closing paren of the RGBA value transitioned back into the value state from value-parenthesis.
This should resolve #86 also - I just added a test case for that to my PR.