unbinding via destroy does not work correctly

[Zangetsu]

jeditable should use namespaced events (http://docs.jquery.com/Namespaced_Events) to bind the specified event. Otherwise calling editable('destroy') will unbind all other events bound to the selector.

Example:
$('div').click(function() {
alert('Hanlder 1 running');
});

$('div').editable('http://www.example.com/save.php');

Now calling $('div').editable('destroy') will unbind both the first handler and the handler bound via editable.

Solution:
Let jeditable bind a namespaced event. Add the following code somewhere to the initialization part of jeditables code:
settings.event += '.editable';

[tuupola]

I woudl rather leave the choice of namespacing or not to the developer. You can call with Jeditable with:

 $('div').editable('http://www.example.com/save.php' {
      event: 'click.editable'
 });

However I agree the default event should be namespaced. Will fix. Thanks for the heads up!

[tuupola]

Fixed in Git.

[twig]

Hi I'm having trouble trying to figure out WHEN to destroy the jEditable instance.

I tried onblur but that prevented the controls from being removed.

[twig]

what i currently have is

function comment_edit() {
  var obj = $(this);
  var id = obj.attr('id').split('-')[2];

  var options = {
    onblur: function() {
      $('#comment-' + id + ' .comment-body').reset().editable('destroy');
    }
  }

  $('#comment-' + id + ' .comment-body').editable('http://www.example.com/save.php', options).trigger('click');
}

Which doesn't seem to work. I believe I need some way to reset() the form elements first.

[tuupola]

What are you trying to achieve? Why do you want to destroy Jeditable onblur?

[twig]

sorry I didnt explain myself.

i have an "edit" button which begins the editing process on another element (hence, the trigger).

when i am done editing (accept using the submit button), i want the edit ability to be removed.

i used onblur, but i changed it to be onreset and it is working fine now.
thanks!

[tuupola]

You do not need to do this by yourself. Jeditable goes back to normal (removes the form displays the new HTML) automatically after you click submit.

[twig]

yeah but the element becomes editable if i click on it
this is not something I want because I have links on it, and if i click on the link the edit form appears

[tuupola]

I guess you have some misunderstanding how Jeditable works. I say again. Jeditable closes the form and goes back to HTML automatically. You do NOT need to do it by yourself.

Also the way you trigger Jeditable inside comment_edit() function is quite unorthodox and un-jQuery way. Atleast to me.

More jQuerish would be binding Jeditable and trigger element on onload event. You can also bind using some custom event such as "edit" or "foo". Then when your trigger element is clicked just call .trigger("foo") on the edited element. This way when the edited element is clicked it will not become a form.

Here is one example: http://stackoverflow.com/questions/366595/jeditable-activate-edit-of-x-by-clicking-on-y

[twig]

No no, I do understand how it works, but as you said I am using it differently.

Thanks for that example, its exactly what I was after!