This repository was archived by the owner on Jul 29, 2022. It is now read-only.
Destroy now calls plugin reset. Destroy also properly deallocates resour...#125
Closed
Scottmitch wants to merge 4 commits intoNicolasCARPi:masterfrom
Closed
Destroy now calls plugin reset. Destroy also properly deallocates resour...#125Scottmitch wants to merge 4 commits intoNicolasCARPi:masterfrom
Scottmitch wants to merge 4 commits intoNicolasCARPi:masterfrom
Conversation
…ources if destroyed while editing
Author
|
The test case has been updated to demonstrate these modifications. |
…ee elements when clean up was attempted.
Author
|
Test case updated to reflect last commit's changes. |
…Corrected 'this' to 'self' where applicable.
Author
|
Test case updated. Plugins now have |
Author
|
@tuupola - Any updates on this being merged into the release? |
NicolasCARPi
added a commit
that referenced
this pull request
Feb 15, 2018
Owner
|
Hello, Thank you for this very nice contribution. Your code has been merged! :) Cheers, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...ces if destroyed while editing
Address issue #124