This repository was archived by the owner on Jul 29, 2022. It is now read-only.
Get text instead of html for callback result#214
Merged
NicolasCARPi merged 1 commit intoNicolasCARPi:experimentalfrom Feb 20, 2020
Merged
Get text instead of html for callback result#214NicolasCARPi merged 1 commit intoNicolasCARPi:experimentalfrom
NicolasCARPi merged 1 commit intoNicolasCARPi:experimentalfrom
Conversation
Owner
|
Hello, Thank you for your contribution. I agree that returning the text is better. Note: this would be a breaking change for users using callbacks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the callback option function returns innerHTML as a result. This means the value that gets returned will have HTML entities like
&. You can see this in action in this jsfiddle:https://jsfiddle.net/mhrvzdas/3/
It seems like it would be more useful to return the text content that the user edited into place rather than its HTML representation. This commit makes this happen.