This repository was archived by the owner on Jul 29, 2022. It is now read-only.
HTML5 form plugin, validation constraints & WAI-ARIA/accessibility#87
Closed
nfreear wants to merge 8 commits intoNicolasCARPi:masterfrom
Closed
HTML5 form plugin, validation constraints & WAI-ARIA/accessibility#87nfreear wants to merge 8 commits intoNicolasCARPi:masterfrom
nfreear wants to merge 8 commits intoNicolasCARPi:masterfrom
Conversation
…for Jeditable * It adds HTML5 form input types - eg. type="number".. * ..Form validation constraints - eg. required, pattern= .. * And, improves keyboard accessibility using WAI-ARIA roles etc.
…QUnit tests * Needed to bump the jQuery version from 1.2.6 to 1.4.4 (likely minimum)
…tests * Fix robustness of `.checkValidity()` * Add function `typeof` unit tests to `tests/index.html`
…nternet Explorer * _supportInType private function based on "Dive into HTML5" example, * http://diveintohtml5.info/everything.html * Re-order QUnit tests
Author
|
Hi Adell,
Yours, Nick |
NicolasCARPi
added a commit
that referenced
this pull request
Feb 20, 2018
So I almost added all of the code from the pull. Fixed the tab key triggering edit, now you can tab the inputs and if you type another key it'll go into edit mode. Instead of adding a plugin, I added it in the code directly, and merged the text type with html5_text because now everyone should do html5 anyway :)
Owner
|
Hello @nfreear, Thank you very much for this very good pull request :) I have merged most of your changes! Cheers, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Adell,
Please pull (see bug #84):
contributed/jquery.jeditable.html5.jstests/index.htmlhtml5.htmlAdditional supported types (so far):
<input type=text >), "number", "email", "url".Additional configuration properties:
Additional function:
$(selector).editableAriaShim()HTML5 forms shim:
$(selector).checkValidity()Many thanks, Nick