Add get all css functions method #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinamic
reviewed
Oct 8, 2024
| * | ||
| * @return array<int, CSSFunction> | ||
| */ | ||
| public function getAllFunctions($mElement = null) |
There was a problem hiding this comment.
Nitpick: Could we think of a better name for this? Maybe getFunctionsRecursively()?
There was a problem hiding this comment.
Nitpick: Could we think of a better name for this? Maybe
getFunctionsRecursively()?
I'm following the naming scheme of the file eg. getAllValues, getAllRulesets, etc.
dinamic
reviewed
Oct 8, 2024
| } elseif ($oElement instanceof Rule) { | ||
| $this->allFunctions($oElement->getValue(), $aResult); | ||
| } elseif ($oElement instanceof CSSFunction) { | ||
| $aResult[] = $oElement; |
There was a problem hiding this comment.
Should we consider using generators to reduce memory usage? Would it be worthy 🤔
There was a problem hiding this comment.
Should we consider using generators to reduce memory usage? Would it be worthy 🤔
Nice. Yet I don't think this would go well with upstream if this change makes it there :) (very conservative. Maybe with good reason)
dinamic
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.