Runner: use StatusWriter for caught errors #1062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Errors should go to `STDERR`. This was mostly handled in PR 1010. However, the `Runner` class contains two `catch (DeepExitException $e)` blocks which are used to exit "early", both for legitimate requests (`--version`, `-i` etc), as well as for error output. This commit changes how the output is handled in these catch blocks, to differentiate between legitimate requests (exit code `0`) and error output, sending legitimate output to `STDOUT` and sending error output to `STDERR`. Includes updating a unit test to reflect the change. Related to squizlabs/PHP_CodeSniffer 1612
|
Rebased without changes. Merges once the build has passed again. |
0db9279 to
4cfbf17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Errors should go to
STDERR. This was mostly handled in PR #1010.However, the
Runnerclass contains twocatch (DeepExitException $e)blocks which are used to exit "early", both for legitimate requests (--version,-ietc), as well as for error output.This commit changes how the output is handled in these catch blocks, to differentiate between legitimate requests (exit code
0) and error output, sending legitimate output toSTDOUTand sending error output toSTDERR.Includes updating a unit test to reflect the change.
Suggested changelog entry
N/A This change is covered by the changelog entry for #1010.
Related issues/external references
Related to squizlabs/PHP_CodeSniffer#1612