Skip to content

ProcessRulesetCliArgsTest: add tests for cache arg #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented May 1, 2025

Description

Follow up on #1005

Was previously blocked by the Config class not allowing for the cache setting to be changed from within the tests, which was fixed via #1068. Also see #966

Suggested changelog entry

N/A

@jrfnl jrfnl added this to the 4.0.0 milestone May 1, 2025
@jrfnl jrfnl marked this pull request as draft May 1, 2025 15:14
Base automatically changed from phpcs-4.0/feature/allow-testing-cache-option to 4.x May 2, 2025 18:39
@jrfnl jrfnl marked this pull request as ready for review May 2, 2025 18:39
Follow up on 1005

Was previously blocked by the `Config` class not allowing for the `cache` setting to be changed from within the tests, which was fixed via 1068. Also see 966
@jrfnl
Copy link
Member Author

jrfnl commented May 2, 2025

Rebased without changes. Merging once the build has passed.

@jrfnl jrfnl force-pushed the phpcs-4.0/feature/ruleset-processcliargstests-add-tests-with-cache-arg branch from 061b38d to df3a307 Compare May 2, 2025 18:41
@jrfnl jrfnl merged commit 483fca2 into 4.x May 2, 2025
54 checks passed
@jrfnl jrfnl deleted the phpcs-4.0/feature/ruleset-processcliargstests-add-tests-with-cache-arg branch May 2, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant