Skip to content

Modernize: use PHP_OS_FAMILY constant (follow-up) #1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrfnl merged 1 commit into from
Jun 4, 2025
Merged

Modernize: use PHP_OS_FAMILY constant (follow-up) #1115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Modernize: use PHP_OS_FAMILY constant (follow-up) 
Follow up on PR 1035, this commit simplifies one more "is this Windows ?" check.
  • Loading branch information
@jrfnl
jrfnl committed Jun 4, 2025
commit 5d76334cfc135c26baa357c9aa007072f4f2309e
2 changes: 1 addition & 1 deletion src/Util/Common.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ public static function isStdinATTY()
}

// Next try is detecting whether we have `tty` installed and use that.
if (defined('PHP_WINDOWS_VERSION_PLATFORM') === true) {
if (PHP_OS_FAMILY === 'Windows') {
$devnull = 'NUL';
$which = 'where';
} else {
Expand Down