Generic/LowerCaseKeyword: add support for asym visibility keywords #1117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredden
reviewed
Jun 6, 2025
Comment on lines
62
to
75
|
|
||
| class AsymmetricVisibility { | ||
| public(set) int $correctPublicSet; | ||
| protected(set) int $correctProtectedSet; | ||
| private(set) int $correctPrivateSet; | ||
|
|
||
| PubliC(SeT) int $wrongCasePublic; | ||
| PROTECTED(set) array $wrongCaseProtected; | ||
| protected(sEt) int $wrongCaseProtectedSet; | ||
| Private(set) int $wrongCasePrivate; | ||
| private(SET) readonly ?string $wrongCasePrivateSet; | ||
| } | ||
|
|
||
| __HALT_COMPILER(); // An exception due to phar support. |
There was a problem hiding this comment.
Do we need to also provide some test cases where we specify both the get and set visibilities?
Example from https://www.php.net/manual/en/language.oop5.visibility.php#language.oop5.visibility-members-aviz
<?php
class Book
{
public function __construct(
public private(set) string $title,
public protected(set) string $author,
protected private(set) int $pubYear,
) {}
}There was a problem hiding this comment.
I've done that in most other PRs, but this sniff doesn't look "around", i.e. it doesn't do any token walking, it just looks at the token passed as $stackPtr, so in this case, making the tests more diverse would not add any value (as it wouldn't be testing anything which isn't already being tested).
Base automatically changed from
php-8.4/feature/file-methods-support-asym-visibility
to
master
June 9, 2025 01:45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Suggested changelog entry
Related issues/external references
Follow up on #851
Follow up on #1116
Related to #734