PEAR/ValidVariableName: update for properties with asymmetric visibility #1118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PEAR sniff does not enforce the naming conventions when no visibility is specified, but for asymmetric visibility, visibility **_is_** specified, even though the "read" visibility may be implied, so in my opinion, the sniff should enforce the naming conventions like normal. Includes tests.
Base automatically changed from
php-8.4/feature/file-methods-support-asym-visibility
to
master
June 9, 2025 01:45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PEAR sniff does not enforce the naming conventions when no visibility is specified, but for asymmetric visibility, visibility is specified, even though the "read" visibility may be implied, so in my opinion, the sniff should enforce the naming conventions like normal.
Includes tests.
Suggested changelog entry
Related issues/external references
Follow up on #851
Follow up on #1116
Related to #734