Skip to content

Tokenizer/PHP: improved tokenization of fully qualified exit/die/true/false/null #1206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrfnl merged 7 commits into from
Sep 4, 2025
Merged

Tokenizer/PHP: improved tokenization of fully qualified exit/die/true/false/null #1206

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1cd9224
Tokenizer/PHP: improved tokenization of fully qualified exit/die/true…
jrfnl Aug 29, 2025
2e70c5f
Generic/UnconditionalIfStatement: handle FQN `true`/`false`/`null`
jrfnl Apr 20, 2025
cdac3b1
Generic/DisallowYodaConditions: handle FQN `true`/`false`/`null`
jrfnl Apr 21, 2025
b33c2df
Generic/[Lower|Upper]CaseConstant: add tests with FQN `true`/`false`/…
jrfnl Mar 1, 2025
e4df0d6
PEAR/ValidDefaultValue: handle FQN `null`
jrfnl Aug 29, 2025
ddeab84
Squiz/ComparisonOperatorUsage: adds tests with FQN `true`/`false`/`null`
jrfnl Apr 20, 2025
e70599f
Squiz/NonExecutableCode: handle FQN `exit`/`die`
jrfnl Aug 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Squiz/ComparisonOperatorUsage: adds tests with FQN true/false/null
  • Loading branch information
@jrfnl
jrfnl committed Aug 30, 2025
commit ddeab8465cfeb4b70ebdace7e94c68c18ef13ec4
6 changes: 6 additions & 0 deletions src/Standards/Squiz/Tests/Operators/ComparisonOperatorUsageUnitTest.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,3 +136,9 @@ if (empty($argTags > 0)) {
}

myFunction($var1 === true ? "" : "foobar");

// Verify that FQN true/false are handled the same as unqualified.
if (true) {}
if (\true) {}
for ($var1 = 10; FALSE; $var1--) {}
for ($var1 = 10; \FALSE; $var1--) {}