CS: clean up use statements #347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up on squizlabs/PHP_CodeSniffer 2714 Note: sniffs which have been removed in 4.0 have been excluded from this commit.
... instead of using fully qualified global/PHP native classes inline.
.... instead of importing the namespace and using partially qualified names. Previously, this was not consistently applied, which led to near-miss bugs/code which only worked by accident, not by design, like in the `Config`, `Fixer` and `Runner` classes, where certain code only worked by the grace of the namespace of the class itself being the top-level `PHP_CodeSniffer` namespace. Note: the JS/CSS tokenizers and a sniff which has been removed in 4.0 have been excluded from this commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CS: alphabetically order import use statements
Follow up on squizlabs/PHP_CodeSniffer#2714
Note: sniffs which have been removed in 4.0 have been excluded from this commit.
CS: always import all used classes [1]
... instead of using fully qualified global/PHP native classes inline.
CS: always import all used classes [2]
.... instead of importing the namespace and using partially qualified names.
Previously, this was not consistently applied, which led to near-miss bugs/code which only worked by accident, not by design, like in the
Config,FixerandRunnerclasses, where certain code only worked by the grace of the namespace of the class itself being the top-levelPHP_CodeSniffernamespace.Note: the JS/CSS tokenizers and a sniff which has been removed in 4.0 have been excluded from this commit.
Suggested changelog entry
N/A