-
-
Notifications
You must be signed in to change notification settings - Fork 78
Add links to issues in the 3.0.0RC4, 3.0.0RC3, 3.0.0RC2, 3.0.0RC1 and 3.0.0a1 sections of the changelog #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add links to issues in the 3.0.0RC4, 3.0.0RC3, 3.0.0RC2, 3.0.0RC1 and 3.0.0a1 sections of the changelog #388
Conversation
… 3.0.0a1 sections of the changelog Also fixed a few typos.
CHANGELOG.md
Outdated
[#1251]: https://github.com/squizlabs/PHP_CodeSniffer/issues/1251 | ||
[#1270]: https://github.com/squizlabs/PHP_CodeSniffer/issues/1270 | ||
[#1233]: https://github.com/squizlabs/PHP_CodeSniffer/issues/1233 | ||
[#1241]: https://github.com/squizlabs/PHP_CodeSniffer/issues/1241 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be a good idea to keep these link lists in numeric order to prevent duplicate link definitions being added. Not much of an issue with short lists like the above, but it could be an issue for longer lists.
(here and elsewhere in this PR - I haven't noticed them not being in numeric order in previous PRs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Up to this point, I generated the list of issues in the order in which they appear in the changelog section for a particular version. I just pushed a new commit ordering the list of issues.
I will check the other lists added in previous PRs to see if any are out of numeric order, and if necessary, I will open a new PR to fix them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'll be adding a markdown linter in CI at some point, which should also help prevent duplicate links from being added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rodrigoprimo ! LGTM and thank you for continuing your work on fixing up the changelog!
… 3.0.0a1 sections of the changelog (#388) Also fixed a few typos.
Description
This PR adds links to all issues in the 3.0.0RC4, 3.0.0RC3, 3.0.0RC2, 3.0.0RC1, and 3.0.0a1 sections of the changelog. It also fixes a few typos.
Related issues/external references
Part of #244
Types of changes
PR checklist