Squiz/ClosingDeclarationComment: add trait support #442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
LGTM Thanks @rodrigoprimo !
I'm milestoning the PR for the 3.10.0 release as it effectively adds a new feature.
This should make it easier to find if a given is registered by this sniff or not.
Now this sniff will also check for the closing declaration comment in traits.
ece17e5 to
6edc97e
Compare
|
Rebased without changes. Merging once the build passes. |
jrfnl
pushed a commit
that referenced
this pull request
Apr 23, 2024
* Squiz/ClosingDeclarationComment: sort registered tokens alphabetically This should make it easier to find if a given is registered by this sniff or not. * Squiz/ClosingDeclarationComment: add trait support Now this sniff will also check for the closing declaration comment in traits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As suggested by @jrfnl in #340 (comment), this PR changes the Squiz.Commenting.ClosingDeclarationComment sniff to require a closing declaration comment for traits as well.
Suggested changelog entry
Squiz.Commenting.ClosingDeclarationComment: closing declaration comments are now required for traits.
Related issues/external references
Suggested in #340 (comment)
Types of changes
PR checklist