Ruleset: add tests for handling of php[cs|cbf]-only attributes within a <ruleset>
#711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in a `<ruleset>` Add tests specifically aimed at verifying `phpcs-only` and `phpcbf-only` attributes for elements within a `<ruleset>` are read and handled correctly.
There was a problem hiding this comment.
Thanks for adding tests for this part of the Ruleset class, @jrfnl!
Overall, it looks good to me. I left an inline comment with a tiny detail.
Besides that, I wonder if you considered adding tests for elements that support the php[cs|cbf]-only attributes but are not covered by these tests, like <severity> and <property>?
Update: ignore the paragraph above; somehow, I missed #712 when I looked at the other open PRs before reviewing this one.
rodrigoprimo
approved these changes
Dec 2, 2024
jrfnl
added a commit
that referenced
this pull request
Dec 2, 2024
…in a `<ruleset>` (#711) Add tests specifically aimed at verifying `phpcs-only` and `phpcbf-only` attributes for elements within a `<ruleset>` are read and handled correctly.
jrfnl
added a commit
that referenced
this pull request
Dec 2, 2024
…in a `<ruleset>` (#711) Add tests specifically aimed at verifying `phpcs-only` and `phpcbf-only` attributes for elements within a `<ruleset>` are read and handled correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add tests specifically aimed at verifying
phpcs-onlyandphpcbf-onlyattributes for elements within a<ruleset>are read and handled correctly.Suggested changelog entry
N/A
Related issues/external references
This PR is part of a series of PRs expanding the tests for the
Rulesetclass.