refactor: implement packages dependencies

[adonyssantos]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
palm-tree-css	❌ Failed (Inspect)			Apr 15, 2024 0:58am

[ehmenzala]

Could you briefly elaborate on the refactor you have made?

[adonyssantos]

Could you briefly elaborate on the refactor you have made?

Sure, we are importing the @palm-tree-css/core package in @palm-tree-css/semantic and @palm-tree-css/utilities-class. But, before my changes, we had been using a relative path to import it and now with my changes, we are importing it using an absolute path (via the npm workspaces/dependencies).

Everything is working well, but when I try to compile @palm-tree-css/semantic or @palm-tree-css/utilities-class have an error.

Error on the GH action pipeline: https://github.com/adonyssantos/palm-tree-css/actions/runs/8681917730/job/23805407926?pr=69

Screenshot:

[ehmenzala]

I suspect GitHub Actions can't fine any packages because of its current working directory. You may have to cd into the root of the project in order to get to the main package.json file, which contains the packages definitions. This can be achieved specifying the working directory for the Build Sass 🫶🏼's job run step that builds all the packages using the working-directory property. Check this Stack Overflow answer.

- name: Build Sass 🫶🏼
     working-directory: <...> ⬅️
     run: npm run build --workspace=packages

[adonyssantos]

I suspect GitHub Actions can't fine any packages because of its current working directory. You may have to cd into the root of the project in order to get to the main package.json file, which contains the packages definitions. This can be achieved specifying the working directory for the Build Sass 🫶🏼's job run step that builds all the packages using the working-directory property. Check this Stack Overflow answer.

- name: Build Sass 🫶🏼
     working-directory: <...> ⬅️
     run: npm run build --workspace=packages

It isn't a problem of the GH action. In local the problem persists

[adonyssantos]

This will not be worked on for the time being