Fix an exception when the host is not connected to host-only interface#268
Merged
legal90 merged 2 commits intoParallels:masterfrom Jul 11, 2016
Merged
Fix an exception when the host is not connected to host-only interface#268legal90 merged 2 commits intoParallels:masterfrom
legal90 merged 2 commits intoParallels:masterfrom
Conversation
This data is not needed in 'action/network', so we can skip it.
…st-only interface
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similarly to the problem described in #266, Host-Only interfaces could be also not connected to the host machine, so it causes an exception when Vagrant tries to parse its IP:
This PR fixes that error by an additional check.
Also, I've removed fetching DHCP details from driver's method
#read_host_only_interfaces, because it is actually not needed forNetworkaction.