fix: broken custom vagrantfile support#368
Merged
legal90 merged 1 commit intoParallels:masterfrom Oct 27, 2020
Merged
Conversation
Collaborator
|
Verified. Works good. |
Collaborator
|
This fix has been released in vagrant-parallels |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
vagrant package --vagrantfile myvagrantfileis broken.It copies the custom vagrant to the box archive, however the custom vagrantfile
includes/_Vagrantfileis never loaded by the actual vagrantfile./vagrantfileThis PR adds the package_vagrantfile action (stolen from the virtualbox provider).
This means that the following template will be rendered:
https://github.com/hashicorp/vagrant/blob/6e670777aff01043b7c21e60dd2ce95b5e433806/templates/package_Vagrantfile.erb#L10
Causing the custom vagrantfile that is already copied to actually be referenced and to work.