Implement "mount_options" and "mount_type" capabilities, persisting shared folders after manual reboot#377
Merged
romankulikov merged 3 commits intoParallels:masterfrom Dec 14, 2020
Conversation
Among the other things, it enables the auto-mount of shared folder after a manual guest reboot
This commit reverts Parallels@04a4770 as it's not needed anymore. Thanks to "mount_name" synced folder capability, the multi-mount of a single shared folder works just fine
This was referenced Dec 13, 2020
Closed
| mount_uid = detected_ids[:uid] | ||
| mount_gid = detected_ids[:gid] | ||
|
|
||
| mount_options << "uid=#{mount_uid}" |
Collaborator
There was a problem hiding this comment.
Just curious why are uid/gid mount options used but not share?
Collaborator
|
Frankly speaking I can hardly understand what's going on this change-set. So my review ineffective. Sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ports the functionality "Persist Shared Folders after manual reboot" for Linux gusest, which has been recently implemented in upstream Vagrant :
Now shared folder mounts are added to
/etc/fstabon the guest side, so the they will be properly re-mounted after a "manual" reboot of the VM.Fixes #376
Fixes #290