Fix shared folder mount on the VM reboot#391
Merged
legal90 merged 2 commits intoParallels:masterfrom Jun 23, 2021
Merged
Conversation
In this case shared folders will be setup (via `prlctl`) before the VM is booted, so the filesystem will be available in the guest OS on early stage
That will prevent VM from boot failure if the shared folder (filesystem) is not available.
From the `man mount`:
_netdev The filesystem resides on a device that requires network access (used to prevent the system from
attempting to mount these filesystems until the network has been enabled on the system).
Collaborator
Author
|
Acceptance tests are passing successfully. @romankulikov Could you please confirm if that's OK to use |
Collaborator
|
Sorry for being late here. Frankly speaking |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a critical bag introduced in
vagrant-parallelsv2.2.0 (Linux guests only): #389Changes:
Move shared folder setup from
enablestage toprepare. In this case shared folders will be setup in the VM (viaprlctl) before the VM is booted, so the filesystem will be available in the guest OS on early stage.In
virtualboxprovider it is done similarly: https://github.com/hashicorp/vagrant/blob/22795b161bf67a4c0ebbe32c9ce8777cb888c4a7/plugins/providers/virtualbox/synced_folder.rb#L17-L19Add
_netdevmount option by default to allprl_fsfilesystems. That will prevent VM from boot failure if the shared folder (filesystem) is not available.virtualboxprovider does the same for vboxfs: https://github.com/hashicorp/vagrant/blob/5b501a3fb05ed0ab16cf10991b3df9d231edb5cf/plugins/providers/virtualbox/cap/mount_options.rb#L25From
man mount: