Skip to content

Fix #398 missing ip forwarding#399

Merged
legal90 merged 7 commits intoParallels:masterfrom
jmfrank63:fix_398_missing_ip_forwarding
Jul 14, 2021
Merged

Fix #398 missing ip forwarding#399
legal90 merged 7 commits intoParallels:masterfrom
jmfrank63:fix_398_missing_ip_forwarding

Conversation

@jmfrank63
Copy link
Contributor

This is a cumulative PR containing fixes for broken port forwarding #393, failing test suite #395 and
#398 Guest and Host IP are ignored.

Usually, I don't subscribe to have more than one issue fixed in a PR, but the other two actually block any further progress.

There are no tests for the IP and only Guest IP is tested so far, changed Host IP has to be confirmed.

@legal90
Copy link
Collaborator

legal90 commented Jul 14, 2021

Hi @jmfrank63,
Thank you very much for your contribution! I'll do my best to review and release it today

@legal90 legal90 self-assigned this Jul 14, 2021
@legal90 legal90 merged commit a752b4d into Parallels:master Jul 14, 2021
@legal90 legal90 linked an issue Jul 14, 2021 that may be closed by this pull request
@legal90 legal90 linked an issue Jul 14, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test Suite fails with ArgumentError due to move to ruby3 Vagrant 2.2.17 forwarding ports

2 participants