Conversation
legal90
requested changes
Dec 14, 2022
Collaborator
legal90
left a comment
There was a problem hiding this comment.
Hi @bineesh-n, @alevlasu
Thank you for your contribution! Could you please check my comments and questions?
Unfortunately, I don't have ARM-based Mac to test it myself, but I trust your solution 👍 .
7b7fdc3 to
300aa9f
Compare
Contributor
Author
|
Hi @legal90 Thanks for your comments. I've updated the code as per your suggestions now. |
legal90
approved these changes
Dec 15, 2022
Collaborator
|
Thank you @bineesh-n ! I will merge it now. P.s. To Parallels folks: |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.