driver: Fix the detection of VM IP using prlctl command#440
Merged
Conversation
Previous statement with || operator always returned empty string if it was returned by read_guest_ip_dhcp. Now we are checking the result properly. Also, I added the loop to make sure that we wait for the real IP instead of returning '' expecting the SSH client to retry.
Contributor
|
Still it can't detect IP from macvms. See the result of ssh-config : @legal90 I'm no ruby/vagrant expert, I think as per the implementation, 5 times trying for ip & wait 2 seconds, is not enough for macvms. Instead of |
bineesh-n
reviewed
Mar 23, 2023
bineesh-n
reviewed
Mar 23, 2023
bineesh-n
reviewed
Mar 23, 2023
Contributor
|
Hi @legal90 I think this has some additional code, which are not required. I've commented it. I can do the changes if you want. IP came correctly with these changes though. |
Collaborator
Author
|
Thank you for the review, @bineesh-n ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It completes the fix introduced in #434
The previous statement with
||operator always returned empty string if it was returned byread_guest_ip_dhcp. Now we are checking the result properly.Also, I added the loop to make sure that we wait for the real IP instead of returning
''expecting the SSH client to retry.