Skip to content

Commit b32bc7a

Browse files
dekajpscottgonzalez
authored andcommitted
Slider: Add missing unit test cases for values method
Closes jquerygh-1573 (cherry picked from commit 4c5cd20)
1 parent 0cc39f2 commit b32bc7a

File tree

1 file changed

+49
-3
lines changed

1 file changed

+49
-3
lines changed

tests/unit/slider/slider_methods.js

Lines changed: 49 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,54 @@ test( "value", function() {
110110
equal( element.slider( "value" ), 460, "value is restricted to maximum valid step" );
111111
});
112112

113-
//test( "values", function() {
114-
// ok(false, "missing test - untested code is broken code." );
115-
//});
113+
test( "values, single step", function() {
114+
expect( 8 );
115+
116+
var element = $( "<div></div>" ).slider( {
117+
range: false,
118+
min: 10,
119+
max: 100,
120+
step: 1,
121+
values: [ 20 ]
122+
} );
123+
124+
deepEqual( element.slider( "values" ), [ 20 ], "range: false, values - get value for handle" );
125+
equal( element.slider( "values", 0 ), 20, "values (index) - get value of handle" );
126+
127+
element.slider( "values", 0, 5 );
128+
equal( element.slider( "values", 0 ), 10, "values (index) - restrict against min" );
129+
130+
element.slider( "values", 0, 110 );
131+
equal( element.slider( "values", 0 ), 100, "values (index) - restrict against max" );
132+
133+
element.slider( "option", "range", true );
134+
element.slider( "values", [ 20, 90 ] );
135+
136+
deepEqual( element.slider( "values" ), [ 20, 90 ], "range: true, values - get value for all handles" );
137+
equal( element.slider( "values", 0 ), 20, "values (index) - 1st handle" );
138+
equal( element.slider( "values", 1 ), 90, "values (index) - 2nd handle" );
139+
140+
element.slider( "values", [ 5, 110 ] );
141+
deepEqual( element.slider( "values" ), [ 10, 100 ], "values - restricted against min and max" );
142+
element.slider( "destroy" );
143+
} );
144+
145+
test( "values, multi step", function() {
146+
expect( 2 );
147+
148+
var element = $( "<div></div>" ).slider( {
149+
range: false,
150+
min: 9,
151+
max: 20,
152+
step: 3,
153+
values: [ 9, 12 ]
154+
} );
155+
deepEqual( element.slider( "values" ), [ 9, 12 ], "values - evenly divisible by step" );
156+
157+
element.slider( "values", [ 10, 20 ] );
158+
deepEqual( element.slider( "values" ), [ 9, 18 ], "values - not evenly divisible by step" );
159+
160+
element.slider( "destroy" );
161+
} );
116162

117163
})( jQuery );

0 commit comments

Comments
 (0)