Move plugin to visitor API #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Looks good, thanks for contributing! It will take a few days until I can push out a new version as I'm busy with exams ATM and I'd like to add at least one test around nesting. |
Owner
|
Nvm the wait, I went ahead an published a new version |
|
Thanks guys ! |
6 tasks
Owner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
postcss-nestedmoved to visitor API (in version 5.0.2) there is a problem with correctness of processing nested rules using this plugin.This problem discussed in more details in postcss/postcss#1611 (comment)
So I tried to fix it by moving your plugin to visitor API too and this fixed problem. All test in repo was passed but maybe you have additional checks