Skip to content

Added create-react-class #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 25, 2017
Merged

Added create-react-class #20

merged 2 commits into from
Jun 25, 2017

Conversation

Floriferous
Copy link
Contributor

Fixes #19.

willbutler
willbutler requested changes Jun 11, 2017
View reviewed changes
Copy link
Collaborator

@willbutler willbutler left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to add create-react-class to the dependencies in package.json.

@Floriferous
Copy link
Contributor Author

Obviously :) thanks!

@willbutler willbutler merged commit b0b2f86 into RickWong:master Jun 25, 2017
@Floriferous
Copy link
Contributor Author

Not sure why, but this came back to bite me this morning. I see in the history that I was confusing react-create-class and create-react-class, which I didn't correct inside package.json.

@Floriferous Floriferous mentioned this pull request Feb 15, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willbutler willbutler willbutler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Floriferous @willbutler