Added configFile option #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Obi-Dann
reviewed
Oct 27, 2020
src/index.js
Outdated
| "Validate generated `*.d.ts` files and fail if an update is needed (useful in CI). Defaults to `false`", | ||
| type: "boolean", | ||
| }, | ||
| configFile: { |
Contributor
There was a problem hiding this comment.
I'd suggest calling it prettierConfigFile to make it clear that it has nothing to do with the loader config. Or perhaps extending formatter to support objects, eg:
formatter: {
type: 'prettier',
configFile: './.prettierrc'
}
Contributor
Author
There was a problem hiding this comment.
Okay, im rename it and update pull request soon
Contributor
There was a problem hiding this comment.
Thanks! Really sorry about the delay, I added the comment ages ago but forgot to submit the review.
Obi-Dann
approved these changes
Oct 29, 2020
Contributor
Obi-Dann
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the PR, going to create a release shortly!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.