Skip to content

Update docs #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 29, 2019
Merged

Update docs #9

merged 4 commits into from
Oct 29, 2019

Conversation

Obi-Dann
Copy link
Contributor

As per suggestions from @adriangodong in #7:

Thank you for bringing this package up to the latest version!
While working with this package, I found several issues that can be clarified in the documentation:

  • This package no longer replaces css-loader, but it has to be added after css-loader
  • There's mentioned of peer dependency to css-loader, but due to the requirement above, this is no longer relevant
  • css-loader will need to be configured to output CSS Modules (e.g. options: { modules: true; })

Changes:

  • Adding Upgrade guide from v1 to README
  • Remove css-loader from peer dependencies
  • Updating examples with the correct use of CSS Modules options: { modules: true; }

@Obi-Dann Obi-Dann mentioned this pull request Sep 16, 2019
@CoericK
Copy link

CoericK commented Sep 16, 2019

The css-loader option

namedExport: true

Is not longer supported on css-loader v3.x

That will trigger an error

options has an unknown property 'namedExport'. These properties are valid:
   object { url?, import?, modules?, sourceMap?, importLoaders?, localsConvention?, onlyLocals? }

@Obi-Dann
Copy link
Contributor Author

Good point, going to remove it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants