Added the ability to set the background color#34
Closed
PGMacDesign wants to merge 1 commit intoTibolte:bugfix/restore_statefrom
PGMacDesign:patch-1
Closed
Added the ability to set the background color#34PGMacDesign wants to merge 1 commit intoTibolte:bugfix/restore_statefrom PGMacDesign:patch-1
PGMacDesign wants to merge 1 commit intoTibolte:bugfix/restore_statefrom
PGMacDesign:patch-1
Conversation
Added 2 methods for setting the background color of the Elastic view. It should take in either an int color or a String and parse the color. If the string is null or the parsing fails, nothing will be set and it will retain the original color
Owner
|
You're doing a PR into the wrong branch, don't target restore_state but master. That reminds me I have to delete this old branch :) |
Contributor
Author
|
Ha. Apologies, I'll make a pull request to master |
Contributor
Author
|
Updated with new pull: |
Contributor
Author
|
I see that the merge went through, but it looks like the gadle / maven builds are still the old version. Any chance you could update the file whenever you have some free time? Thanks! |
Owner
|
Yes good point I'll try to do that asap and publish a new version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added 2 methods for setting the background color of the Elastic view. It should take in either an int color or a String and parse the color. If the string is null or the parsing fails, nothing will be set and it will retain the original color
I created a pull request into the bugfix branch (not master) so you can update after testing if you would like. I tested it myself before pushing and it seems to have no issues that I can find.