Glob and module lookups #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Owner
|
Done. |
Closed
|
Looks good to me. 👏 |
This builds on the efforts by @toomuchdesign in #7 and #13. Instead of using a `glob` option and being forced to pick one or the other it now uses `isGlob` to detect what kind of resolve function should be used. This allows both types to be used. Example: ```css @import "suitcss-utils-display"; /* node_modules */ @import "./theme.css"; /* relative path */ @import "./components/*.css" /* glob */ ```
b6b105f to
d169e75
Compare
This was referenced Jan 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the feature discussed in #7
@toomuchdesign Can you have a quick look at this? I went a slightly different route and instead of reverting all your commits it was quicker to make a fresh branch. Sorry! :)
I added a couple of tests to ensure the plugin function directs the import to the correct resolve function.
@TrySound Can you add me to the npm package please? :)