Skip to content

Values starting with letter 'e' and a digit #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PEsteves8 opened this issue May 29, 2019 · 1 comment · Fixed by #49
Closed

Values starting with letter 'e' and a digit #48

PEsteves8 opened this issue May 29, 2019 · 1 comment · Fixed by #49

Comments

@PEsteves8
Copy link
Contributor

Hi,

In situations in which the value is a string starting with the letter 'e' followed by a digit, the parser will assume that the string starts with a numeric value and parses it accordingly resulting in a string looking like 'NaNrestofstring'.

We got this when the parser was processing animation names that were hashed.

You can easily reproduce this issue by adding the following test:

 {
    fixture: "e06d4a",
    expected: false
 }

The result will instead be 'NaN6d4a'.

I'll happily submit a PR to fix this.

Thanks

@alexander-akait
Copy link
Collaborator

PR welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants