fix: invalidate values starting with 'e' + digit #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48
Prevents values starting with 'e' + digit from being considered numbers.
Currently, if the first character is an 'e' and it's followed by a digit,
containsNumber
will be set totrue
.This results in values that aren't units at all, being processed as such. One such example is animation names which, after hashing can be broken.
The package
cssnano/postcss-convert-values
, runs this line using the return value from postcss-value-parse here https://github.com/cssnano/cssnano/blob/master/packages/postcss-convert-values/src/index.js#L26An input of e6abc would be converted to NaNabc.
The issue causes animation bugs in which a rule like:
would be converted to:
The animation name reference in the keyframes declaration would remain the original one, breaking the animation.