Skip to content

chore(release): 4.0.0 #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2019
Merged

chore(release): 4.0.0 #51

merged 1 commit into from
Jun 3, 2019

Conversation

alexander-akait
Copy link
Collaborator

/cc @TrySound

@TrySound
Copy link
Owner

TrySound commented Jun 3, 2019

@evilebottnawi drop node v6 support. Or does stylelint still support it?

@alexander-akait
Copy link
Collaborator Author

Yes, we can drop node@6

@alexander-akait
Copy link
Collaborator Author

alexander-akait commented Jun 3, 2019 •
edited
Loading

@TrySound should we setup engine in package.json?

@TrySound
Copy link
Owner

TrySound commented Jun 3, 2019

I think mentioning in changelog should be enough.

@alexander-akait
Copy link
Collaborator Author

@TrySound Can i merge this and do release?

TrySound
TrySound approved these changes Jun 3, 2019
View reviewed changes
Copy link
Owner

@TrySound TrySound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, forgot to approve.

@alexander-akait alexander-akait merged commit 79294f7 into master Jun 3, 2019
@alexander-akait alexander-akait deleted the chore-release-4.0.0 branch June 3, 2019 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrySound TrySound TrySound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexander-akait @TrySound