Skip to content

Add 2.13 support, drop 2.11 #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 14, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
language: scala
dist: trusty

jdk: oraclejdk8
jdk: openjdk11

scala:
- 2.11.12
- 2.12.7
- 2.13.1

before_script:
- "export DISPLAY=:99.0"
Expand All @@ -22,6 +22,5 @@ before_script:
- export PATH=$PWD/selenium-bin:$PATH

script:
- sbt ++$TRAVIS_SCALA_VERSION test
- sbt ++$TRAVIS_SCALA_VERSION publishLocal
- cd example && sbt ++$TRAVIS_SCALA_VERSION compile jquery-global-demo/fullOptJS jquery-bundler-demo/compileStatics
- sbt +test +publishLocal
- cd example && sbt compile jquery-global-demo/fullOptJS jquery-bundler-demo/compileStatics
29 changes: 12 additions & 17 deletions build.sbt
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
import org.openqa.selenium.chrome.ChromeOptions


name := "udash-jquery"

inThisBuild(Seq(
version := "3.0.0",
version := "3.0.1",
organization := "io.udash",
))

val commonSettings = Seq(
scalaVersion := "2.12.7",
crossScalaVersions := Seq("2.11.12", "2.12.7"),
scalaVersion := "2.13.1",
crossScalaVersions := Seq("2.12.10", "2.13.1"),
scalacOptions ++= Seq(
"-feature",
"-deprecation",
Expand All @@ -19,18 +19,13 @@ val commonSettings = Seq(
"-language:dynamics",
"-language:postfixOps",
"-language:experimental.macros",
"-Xfuture",
"-Xfatal-warnings",
"-Xlint:_"
"-Xlint:_",
"-Ywarn-unused:_,-explicits,-implicits",
"-Ybackend-parallelism", "4",
"-Ycache-plugin-class-loader:last-modified",
"-Ycache-macro-class-loader:last-modified",
),
scalacOptions ++= {
if (scalaBinaryVersion.value == "2.12") Seq(
"-Ywarn-unused:_,-explicits,-implicits",
"-Ybackend-parallelism", "4",
"-Ycache-plugin-class-loader:last-modified",
"-Ycache-macro-class-loader:last-modified"
) else Seq.empty
}
)

val commonJSSettings = Seq(
Expand All @@ -55,9 +50,9 @@ lazy val root = project.in(file("."))
commonJSSettings,

libraryDependencies ++= Seq(
"org.scala-js" %%% "scalajs-dom" % "0.9.6",
"org.scalatest" %%% "scalatest" % "3.0.5" % Test,
"com.lihaoyi" %%% "scalatags" % "0.6.7" % Test
"org.scala-js" %%% "scalajs-dom" % "0.9.7",
"org.scalatest" %%% "scalatest" % "3.0.8" % Test,
"com.lihaoyi" %%% "scalatags" % "0.7.0" % Test
),

Compile / npmDependencies += "jquery" -> "3.3.1",
Expand Down
19 changes: 7 additions & 12 deletions example/build.sbt
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
name := "jquery-demo"

inThisBuild(Seq(
version := "3.0.0",
version := "3.0.1",
organization := "io.udash",
))

val commonSettings = Seq(
scalaVersion := "2.12.7",
crossScalaVersions := Seq("2.11.12", "2.12.7"),
scalaVersion := "2.12.10",
crossScalaVersions := Seq("2.12.10"), //todo 2.13
scalacOptions ++= Seq(
"-feature",
"-deprecation",
Expand All @@ -16,18 +16,13 @@ val commonSettings = Seq(
"-language:existentials",
"-language:dynamics",
"-language:postfixOps",
"-Xfuture",
"-Xfatal-warnings",
"-Xlint:_",
"-Ywarn-unused:_,-explicits,-implicits",
"-Ybackend-parallelism", "4",
"-Ycache-plugin-class-loader:last-modified",
"-Ycache-macro-class-loader:last-modified"
),
scalacOptions ++= {
if (scalaBinaryVersion.value == "2.12") Seq(
"-Ywarn-unused:_,-explicits,-implicits",
"-Ybackend-parallelism", "4",
"-Ycache-plugin-class-loader:last-modified",
"-Ycache-macro-class-loader:last-modified"
) else Seq.empty
},

libraryDependencies ++= Dependencies.deps.value
)
Expand Down
6 changes: 3 additions & 3 deletions example/project/Dependencies.scala
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@ import org.portablescala.sbtplatformdeps.PlatformDepsPlugin.autoImport._
import sbt._

object Dependencies {
val udashCoreVersion = "0.6.1"
val udashJQueryVersion = "3.0.0"
val udashCoreVersion = "0.8.1"
val udashJQueryVersion = "3.0.1"

val deps = Def.setting(Seq[ModuleID](
"io.udash" %%% "udash-core-frontend" % udashCoreVersion,
"io.udash" %%% "udash-core" % udashCoreVersion,
"io.udash" %%% "udash-jquery" % udashJQueryVersion
))

Expand Down
3 changes: 2 additions & 1 deletion example/project/build.properties
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
sbt.version = 1.2.6
# suppress inspection "UnusedProperty"
sbt.version=1.3.2
4 changes: 2 additions & 2 deletions example/project/plugins.sbt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
logLevel := Level.Warn

addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.25")
addSbtPlugin("ch.epfl.scala" % "sbt-scalajs-bundler" % "0.14.0")
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.29")
addSbtPlugin("ch.epfl.scala" % "sbt-scalajs-bundler" % "0.15.0-0.6")
3 changes: 2 additions & 1 deletion project/build.properties
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
sbt.version = 1.2.6
# suppress inspection "UnusedProperty"
sbt.version=1.3.2
4 changes: 2 additions & 2 deletions project/plugins.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ logLevel := Level.Warn

libraryDependencies += "org.scala-js" %% "scalajs-env-selenium" % "0.3.0"

addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.25")
addSbtPlugin("ch.epfl.scala" % "sbt-scalajs-bundler" % "0.14.0")
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.29")
addSbtPlugin("ch.epfl.scala" % "sbt-scalajs-bundler" % "0.15.0-0.6")
2 changes: 1 addition & 1 deletion src/main/scala/io/udash/wrappers/jquery/JQuery.scala
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package io.udash.wrappers.jquery

import org.scalajs.dom._
import org.scalajs.dom.Element

import scala.collection.mutable
import scala.scalajs.js
Expand Down